search

edmundhung / conform

A type-safe form validation library utilizing web fundamentals to progressively enhance HTML Forms with full support for server frameworks like Remix and Next.js.
https://conform.guide
MIT License
1.8k stars 101 forks source link

fix: getInputProps #734

Open lifeiscontent opened 1 month ago

lifeiscontent commented 1 month ago

@edmundhung I'm not sure if this is the right fix, but I noticed in some playwright tests the file input will have an array of undefined values and [undefined,undefined] results in "," when toString() is called

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 24baf23d79bf74a490875bb5952b398a31b7a7d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

edmundhung commented 1 month ago

the file input will have an array of undefined values and [undefined,undefined]

I guess this happens only with a multiple file input on full document reload in which we have to strip the files from the server as it is not serializable.

But I am not sure how it ends up with the value you see there because the initialValue would still be array so it shouldn't set anything to the default value. Do I missed something?

lifeiscontent commented 1 month ago

Do I missed something?

Yeah, I forget which test I came across that was showing it, but if you throw an error in the getInputProps by checking if its an array you'll find it if you run playwright tests

Otherwise, I can follow up when I find it again.