Closed luckymike closed 6 years ago
Hi @luckymike thanks for your contribution! I have looked over the request and think this would be a great change. I can work with you on verifying the changes and making them work with the tests/Travis. I will open up a separate PR for this.
Great, thanks! I believe all that's necessary is updating the config file that travis downloads to use the new consumer_worker_name
env var.
@luckymike can you pull in the latest changes to master to your branch? I have resolved the issues with Travis.
Thanks for your contribution, @luckymike!
It looks like this fails on the PR because $TRAVIS_BRANCH is the target branch of the PR, rather than the source branch:
Per: https://docs.travis-ci.com/user/environment-variables
TRAVIS_BRANCH
: for push builds, or builds not triggered by a pull request, this is the name of the branch. for builds triggered by a pull request this is the name of the branch targeted by the pull request. for builds triggered by a tag, this is the same as the name of the tag (TRAVIS_TAG
).
@luckymike can you try again? I've made the necessary changes to the build script.
Looks like we're closer, but travis is looking for the branch in your repo rather than my fork :)
All right, more changes merged from #32. Let's try this again.
Looks like we're good now!
Master/Slave terminology has lost favor in the industry (e.g. https://medium.com/@mikebroberts/let-s-stop-saying-master-slave-10f1d1bf34df). In addition to being offensive to a lot of folks, it is a poor representation of the interaction between components.
worker
is a widely accepted, accurate substitute for systems with one component coordinates work among one or more other components.This PR replaces all instances of
slave
withworker
. Tests pass with the following updated config file (based on the config file downloaded here: https://github.com/edmunds/shadowreader/blob/master/.travis.yml#L28) :Thank you for considering this to make a more inclusive project.