search

edo9300 / edopro

A script engine for "yu-gi-oh!" and sample gui (former "ygopro")
Other
284 stars 75 forks source link

[Linux] Hardcoded icon paths #140

Open FrankAlbella opened 4 years ago

FrankAlbella commented 4 years ago

The install script for Linux currently creates a .desktop file with a hardcoded icon path. Specially the icon is set to {INSTALL_PATH}/textures/AppIcon.png. This is generally considered bad practice and prevents icon packs from working correctly.

Instead, the icon path should simply read Icon=edopro, and the icon should be moved to the icons folder. Since EDOPro installs locally to the user, this would be in $HOME/.local/share/icons/hicolor/.

The following xdg-icon-resource command can be used to install the icon from install.sh: xdg-icon-resource install --novendor --size 512 $PWD/textures/AppIcon.png edopro. * Note I used size 512 instead of 1024 because Gnome wasn't picking up the icon when I set the size to 1024.

kevinlul commented 4 years ago

Hey there, thanks for reporting this! We're currently swamped by bug reports and server issues right now, but if you're interested, please make a pull request with those files in the config/ folder and I can take care of the rest for our build systems.

GSchuemann commented 4 years ago

Hi Kevinlul,

it seems you misunderstand the bugrepoort from FrankAlbella (or maybe I misunderstand you ;) ). It is about the install Script "install.sh" distributed by your pre compiled builds. Besides that the "io.github.edo9300.EDOPro.desktop.in"in the config folder must also be changed.

I attached both files with the changes suggested buy FrankAlbella, just remove the .txt at the end.

io.github.edo9300.EDOPro.desktop.in.txt install.sh.txt