search

edo9300 / edopro

A script engine for "yu-gi-oh!" and sample gui (former "ygopro")
Other
279 stars 75 forks source link

Cards with art variants getting incorrectly displayed as legal with a custom banlist that has them banned #240

Closed SantiagoRivera92 closed 2 years ago

SantiagoRivera92 commented 2 years ago

My custom banlist contains the following line

90590304 -1 -- Number 41: Bagooska the Terribly Tired Tapir

EDOPRO shows this

image

edo9300 commented 2 years ago

https://github.com/edo9300/edopro/commit/a0cfca32040fdda31e183015bfc9b8b3273a4359 whitelist handling got updated with aliased cards, now you'll have to explicitly list them in the whitelist as well (in your case you're banning the alt art only, not the original one, that is 90590303, in which case both would be properly banned).

SantiagoRivera92 commented 2 years ago

@edo9300

Yeah, I understand that.

However both versions of Bagooska share the same ID, and only one of those is getting correctly banned.

image

image

edo9300 commented 2 years ago

Internally the "original" has the id 90590303, the alternate art has the id 90590304 and is aliased to 90590303, in your banlist you're banning 90590304, thus only the alternate art is being affected.