search

edoardoBaldoni / AGPRIS

0 stars 0 forks source link

dependency on retiring spatial infrastructure packages #1

Open rsbivand opened 1 year ago

rsbivand commented 1 year ago

AGPRIS has strong dependence on at least one of rgdal, rgeos or maptools, but does not seem to use any functionality in code. The usage may have been in raster, which now uses terra instead, or may be in examples or vignettes. Please move all use of rgdal, rgeos or maptools to Suggests: and protect any use against these packages not being present. The packages will be archived in October 2023. See https://r-spatial.org/r/2022/04/12/evolution.html, https://r-spatial.org/r/2022/12/14/evolution2.html and https://rsbivand.github.io/csds_jan23/bivand_csds_ssg_230117.pdf and perhaps view https://www.youtube.com/watch?v=TlpjIqTPMCA&list=PLzREt6r1NenmWEidssmLm-VO_YmAh4pq9&index=1.

See also https://r-spatial.org/r/2023/04/10/evolution3.html, fix best by June, latest October 2023.

rsbivand commented 1 year ago

See also https://r-spatial.org/r/2023/05/15/evolution4.html; take action now and report back! Simply removing the import declarations of rgdal should be sufficient; I think that simply removing rgdal from Imports in the DESCRIPTION file, and library(rgdal) from the examples in bcml.Rd, inla.st.Rd, and mml.Rd should be sufficient. Complete as soon as you can.

edoardoBaldoni commented 1 year ago

Submitted new version of package AGRPIS (now 2.0) excluding rgdal from Imports in DESCRIPTION and including terra in Suggests. Pending manual inspection of the package.

best E

Il giorno mer 7 giu 2023 alle ore 15:13 Roger Bivand < @.***> ha scritto:

See also https://r-spatial.org/r/2023/05/15/evolution4.html; take action now and report back! Simply removing the import declarations on rgeos and rgdal should be sufficient. Simply substitute by terra.

— Reply to this email directly, view it on GitHub https://github.com/edoardoBaldoni/AGPRIS/issues/1#issuecomment-1580790573, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGCTK4NST24X4YNQDFPSMG3XKB47LANCNFSM6AAAAAAXH2HLLQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

rsbivand commented 1 year ago

Good, thanks for letting me know!

edoardoBaldoni commented 1 year ago

thank you

Il giorno gio 8 giu 2023 alle ore 08:54 Roger Bivand < @.***> ha scritto:

Good, thanks for letting me know!

— Reply to this email directly, view it on GitHub https://github.com/edoardoBaldoni/AGPRIS/issues/1#issuecomment-1581990442, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGCTK4LS4DVMT74J7ITUZXDXKFZLZANCNFSM6AAAAAAXH2HLLQ . You are receiving this because you commented.Message ID: @.***>

edoardoBaldoni commented 1 year ago

Updated package on CRAN best E

Il giorno gio 8 giu 2023 alle ore 09:01 Edoardo Baldoni < @.***> ha scritto:

thank you

Il giorno gio 8 giu 2023 alle ore 08:54 Roger Bivand < @.***> ha scritto:

Good, thanks for letting me know!

— Reply to this email directly, view it on GitHub https://github.com/edoardoBaldoni/AGPRIS/issues/1#issuecomment-1581990442, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGCTK4LS4DVMT74J7ITUZXDXKFZLZANCNFSM6AAAAAAXH2HLLQ . You are receiving this because you commented.Message ID: @.***>