search

edoardottt / scilla

Information Gathering tool - DNS / Subdomains / Ports / Directories enumeration
https://edoardoottavianelli.it
GNU General Public License v3.0
933 stars 113 forks source link

Add JSON output support. #35

Closed teezzan closed 3 years ago

teezzan commented 3 years ago

This is a PR for the JSON feature of scilla. This is a work in progress and will be updated as it progresses.

teezzan commented 3 years ago

@edoardottt Is this alright? I am kinda new to this and read somewhere that PRs should be open for any work in progress.

edoardottt commented 3 years ago

perfect :)

edoardottt commented 3 years ago

perfect :)

teezzan commented 3 years ago

@edoardottt, Please check out the AppendWhere function. While this works for every thing except dns, I am faced with the question of adding another parameter to that function. What is your take on that? This is because there is need to pass the dns records as keys too eg SRV. Thanks for your help.

edoardottt commented 3 years ago

If I understood the problem it's okay and I think it's the most clever way to solve this. Just pass another (optional) parameter and the function will use it only if the file type is JSON and the key is DNS. Am I wrong?...

teezzan commented 3 years ago

Yup, that would solve it. I will do that. Thanks

teezzan commented 3 years ago

Please Check it out

edoardottt commented 3 years ago

Sorry I was sleeping :/ ahahah. Everything okay :)

teezzan commented 3 years ago

Alright. Thanks. What's the next thing to do?

edoardottt commented 3 years ago

Well I think you can start working on json.go file adding the key features, like writing the results into the file.
Maybe it's better to start with the easiest ones (directories, ports and subs) and then pass to dns.
What do you think ??

teezzan commented 3 years ago

I think I already did that. I am able to write to the file the result of a scan. Is it possible that I'm missing something?

edoardottt commented 3 years ago

I didn't see this line. right.

So, I'm gonna approve the pr and then if there are changes to do I will open an issue, ok? :+1: