search

edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
24 stars 6 forks source link

Implement periodic boundary conditions #15

Closed axch closed 7 years ago

axch commented 7 years ago

The source comment at https://github.com/edoddridge/MIM/blob/9adaded177146e50a9cea68b64bd5080cf13939b/MIM.f90#L246 deserves to be its own issue.

@edoddridge I understand the regrid branch exists for this purpose. Care to elaborate on your plan of attack, impediments, acceptance criteria, etc? If the work is done, then just enough to document your intentions for posterity :)

edoddridge commented 7 years ago

This is one of the main purposes of the regrid branch along with making the shape and size of the output data consistent with other C-grid ocean models (at the moment the master branch output includes some extra boundary points that are very useful for the model, but not particularly intuitive to the user).

The code on the regrid branch has been edited to alter the size of all arrays, the loop limits have been changed, and the matrix inversion subroutine has been modified. Currently the code on this branch compiles and runs (as can be seen in the output of the tests https://github.com/edoddridge/MIM/blob/regrid/examples/examples%20-%20n%20layer.ipynb), but it hasn't been properly tested yet.

I would like to compare the output of the simulations using the regrid version with the equivalent parts of the output from the master branch. If that comparison goes well, then I think this branch is ready to be merged.

edoddridge commented 7 years ago

I've compared output from the regrid branch and the master branch, and I'm happy that it's working as expected.

This branch does not implement periodic boundary conditions, but the changes in the grid should make that easier to implement at some stage in the future.

rcmusgrave commented 7 years ago

Here's an upvote for periodic boundary conditions. I would like to run channel configurations using this, and that would need periodic in one dimension... Thanks!

edoddridge commented 7 years ago

Thanks for the feedback Ruth! Consider it bumped up the priority list.

rcmusgrave commented 7 years ago

that was fast! I will try to set up my channel problem over the next few weeks, will let you know how it goes. thanks!

On Mon, May 15, 2017 at 12:05 PM, Ed Doddridge notifications@github.com wrote:

Closed #15 https://github.com/edoddridge/aronnax/issues/15 via 59e348a https://github.com/edoddridge/aronnax/commit/59e348a79b1a37250f581c0d5ce6f3eaa6e5a5b8 .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/edoddridge/aronnax/issues/15#event-1082550799, or mute the thread https://github.com/notifications/unsubscribe-auth/AE4OAlrD-mDrLkKyLlkLFZm_j0d0eaVXks5r6He9gaJpZM4MGwvX .