search

edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
23 stars 5 forks source link

MPI cleanup #159

Closed edoddridge closed 7 years ago

edoddridge commented 7 years ago

This PR changes the code that send values to and from the Hypre solver, and changes the loop limits so that it only loops over a single tile of values. This change will be required before MPI parallelisation can be implemented, and is a first step towards that parallelisation. However, this PR is not a complete implementation.

Despite not living up to its aspirational name, I'm merging this branch as is, since it is a useful contribution that cleans up the MPI implementation, and I don't want to carry around outstanding feature branches that are slowly accruing bit rot.

To make the model actually parallel will require additional subroutines to:

codecov[bot] commented 7 years ago

Codecov Report

Merging #159 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #159   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files           5        5           
  Lines        1134     1134           
  Branches       57       57           
=======================================
  Hits         1067     1067           
  Misses         52       52           
  Partials       15       15
Impacted Files Coverage Δ
aronnax.f90 94.28% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca0b004...1a6cc53. Read the comment docs.