search

edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
23 stars 5 forks source link

Fix underflow error and add more compiler flags to test executable #169

Closed edoddridge closed 6 years ago

edoddridge commented 6 years ago

As identified in #168 some runs produced a warning about underflow when they finished. Using a compiler flag to capture these floating point errors caused 7 of the tests to fail.

This PR stops those tests from failing by initialising the output frequencies to zero before the namelists are read. This means that user specified values will over ride the default zeros.

The -Wuninitialized flag was alse added to the test compilation as well.

codecov[bot] commented 6 years ago

Codecov Report

Merging #169 into master will increase coverage by 0.17%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   94.81%   94.98%   +0.17%     
==========================================
  Files           5        5              
  Lines        1273     1277       +4     
  Branches       70       70              
==========================================
+ Hits         1207     1213       +6     
+ Misses         49       47       -2     
  Partials       17       17
Impacted Files Coverage Δ
aronnax.f90 94.81% <100%> (+0.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65c84fb...865cf43. Read the comment docs.