search

edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
23 stars 5 forks source link

Verification page update #173

Closed edoddridge closed 6 years ago

edoddridge commented 6 years ago

Update the verification page of the docs. The numerical core has had a number of updates since the tests were last run. In particular, the use of a doubly periodic domain removes any possibility of boundary effects, which is nice.

I swapped the n-layer tests to using the free-surface, since that now works as expected, and users are more likely to run in that configuration.

I also added two tests for the conservation of momentum. The model is started with a homogeneous, non-zero, velocity field and integrated forward for 20 days. The momentum is nicely conserved. I also set the Coriolis parameter to zero to prevent inertial oscillations: setting a non-zero Coriolis parameter would be a good test, but is not as clean as the one incorporated in this PR.

codecov[bot] commented 6 years ago

Codecov Report

Merging #173 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files           5        5           
  Lines        1277     1277           
  Branches       70       70           
=======================================
  Hits         1213     1213           
  Misses         47       47           
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0892bcd...aa63d94. Read the comment docs.