edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
23 stars 5 forks source link

Add vertical diffusion #177

Closed edoddridge closed 6 years ago

edoddridge commented 6 years ago

This PR implements a naive diffusive mass flux between layers, as discussed in #175. For most simulations the diffusion coefficient, kv, will be set to zero.

It also streamlines the names of the diffusive and viscous parameters, closing #176.

The new functionality is tested in two simulations:

codecov[bot] commented 6 years ago

Codecov Report

Merging #177 into master will increase coverage by 0.62%. The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   94.98%   95.61%   +0.62%     
==========================================
  Files           5        5              
  Lines        1277     1299      +22     
  Branches       70       73       +3     
==========================================
+ Hits         1213     1242      +29     
+ Misses         47       41       -6     
+ Partials       17       16       -1
Impacted Files Coverage Δ
aronnax/driver.py 93.45% <ø> (ø) :arrow_up:
aronnax.f90 95.62% <96.66%> (+0.81%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f03a18...7e9ae12. Read the comment docs.