search

edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
24 stars 6 forks source link

Python 3 compatibility #189

Closed edoddridge closed 6 years ago

edoddridge commented 6 years ago

Given the impending end of life for Python 2, Aronnax should support Python 3. This was highlighted during the JOSS review process: https://github.com/openjournals/joss-reviews/issues/592#issuecomment-382356615

This PR makes Aronnax compatible with Python 3, and updates the test suite to run under both Python 2.7 and 3.6, thereby closing #186.

codecov[bot] commented 6 years ago

Codecov Report

Merging #189 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   90.94%   90.98%   +0.03%     
==========================================
  Files          19       19              
  Lines        1403     1409       +6     
  Branches       76       76              
==========================================
+ Hits         1276     1282       +6     
  Misses        107      107              
  Partials       20       20
Impacted Files Coverage Δ
aronnax/core.py 96.61% <100%> (+0.03%) :arrow_up:
aronnax/driver.py 93.69% <100%> (+0.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b7471e9...ec245a8. Read the comment docs.