search

edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
24 stars 6 forks source link

Python3 compatibility for examples and benchmarks #192

Closed edoddridge closed 6 years ago

edoddridge commented 6 years ago

In #189 I managed to miss the reproduction, example, and benchmarking scripts. Several of these hadn't been updated in quite some time, and the Davis et al. reproduction didn't run because the config file was missing the RelativeWind flag.

While making the benchmarking script compatible with Python 3 I found that the addition of the compiler flag to catch underflow errors caused the model to stop. Squaring very small velocities in the computation of the Bernoulli potential lead to underflow warnings, and the flag was turning these warnings into errors. As mentioned in #191 I've just removed that flag.

codecov[bot] commented 6 years ago

Codecov Report

Merging #192 into master will increase coverage by 0.14%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   90.98%   91.12%   +0.14%     
==========================================
  Files          19       19              
  Lines        1409     1409              
  Branches       76       76              
==========================================
+ Hits         1282     1284       +2     
+ Misses        107      106       -1     
+ Partials       20       19       -1
Impacted Files Coverage Δ
src/model_main.f90 95.68% <0%> (+1.72%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 979a818...ed4067f. Read the comment docs.