Closed edoddridge closed 6 years ago
Merging #198 into master will increase coverage by
0.12%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #198 +/- ##
=========================================
+ Coverage 90.38% 90.5% +0.12%
=========================================
Files 19 19
Lines 1570 1570
Branches 82 82
=========================================
+ Hits 1419 1421 +2
+ Misses 124 123 -1
+ Partials 27 26 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/model_main.f90 | 95.65% <0%> (+1.73%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a636218...64c07dc. Read the comment docs.
Now that Aronnax supports outcropping, it is possible to perform simulations similar to those from Yang et al. (2016), making progress on #60 (though this paper wasn't listed because it required outcropping).
This PR introduces a new example that is similar to their control run. However, the agreement between Aronnax and their simulation is somewhat disappointing - the mean state is noticeably different. Having gone to the effort of creating and running the simulation, I think it's worth including despite the disappointing lack of agreement. It's also a nice demonstration of Aronnax's n-layer capabilities and provides a "research ready" example for future users to hack.
In the new section of documentation I mention that the results are different, and speculate on the numerical differences that might be responsible. I've also included some fancy visualisations and animations in the documentation for this example, which are potential candidates for #94 and make progress on #38.