search

edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
24 stars 6 forks source link

Improved initial guess for external solver routine #206

Closed edoddridge closed 5 years ago

edoddridge commented 5 years ago

The external solver was being given -etastar/dt^2 as an initial guess for etanew. etastar is a much better initial guess, since it should be much closer to the final value.

For the runs with a free surface, this poor choice of initial condition was causing undesirable artefacts in the flow field. The impact was much reduced in the rigid lid simulations, since etastar does not carry any information from the previous timestep's surface pressure correction and therefore has a smaller magnitude.

The blessed output for the two external solver tests with flow fields are updated.

codecov[bot] commented 5 years ago

Codecov Report

Merging #206 into master will increase coverage by 0.15%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   90.41%   90.56%   +0.15%     
==========================================
  Files          19       19              
  Lines        1596     1601       +5     
  Branches       82       82              
==========================================
+ Hits         1443     1450       +7     
+ Misses        126      125       -1     
+ Partials       27       26       -1
Impacted Files Coverage Δ
src/barotropic_mode.f90 100% <100%> (ø) :arrow_up:
src/model_main.f90 95.65% <0%> (+1.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d249b9...b8c2716. Read the comment docs.