edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.

http://aronnax.readthedocs.io/en/latest/

MIT License

23 stars 5 forks source link

Fix alerts identified by lgtm #207

Closed edoddridge closed 5 years ago

edoddridge commented 5 years ago

Turning on LGTM code checker identified a number of issues including unused variables and imports.

This PR fixes those issues.

edoddridge commented 5 years ago

This pull request introduces 2 alerts and fixes 13 when merging d7fbbb68bd8fe2e075762f34db7c4b917f000de7 into b2db2d57cad827cfc54de33b85c920b1b8d56ce6 - view on LGTM.com

new alerts:

2 for Unused import

fixed alerts:

6 for Unused local variable
5 for Unused import
2 for Variable defined multiple times

Comment posted by LGTM.com

codecov[bot] commented 5 years ago

Codecov Report

Merging #207 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #207   +/-   ##
=======================================
  Coverage   90.56%   90.56%           
=======================================
  Files          19       19           
  Lines        1601     1601           
  Branches       82       82           
=======================================
  Hits         1450     1450           
  Misses        125      125           
  Partials       26       26

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b2db2d5...6666f44. Read the comment docs.

edoddridge commented 5 years ago

This pull request fixes 13 alerts when merging 6666f4497036bcb2784e4a2f1fa79834e1066f43 into b2db2d57cad827cfc54de33b85c920b1b8d56ce6 - view on LGTM.com

fixed alerts:

6 for Unused local variable
5 for Unused import
2 for Variable defined multiple times

Comment posted by LGTM.com