search

edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
23 stars 5 forks source link

Open_mfdatarray bug fix #208

Closed edoddridge closed 5 years ago

edoddridge commented 5 years ago

The function open_mfdataarray didn't respect the location of the variables on the grid. This PR introduces a test that can detect that behaviour, and a fix for the problem.

codecov[bot] commented 5 years ago

Codecov Report

Merging #208 into master will increase coverage by 0.07%. The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   90.44%   90.51%   +0.07%     
==========================================
  Files          19       19              
  Lines        1601     1613      +12     
  Branches       82       82              
==========================================
+ Hits         1448     1460      +12     
- Misses        126      127       +1     
+ Partials       27       26       -1
Impacted Files Coverage Δ
aronnax/core.py 95.34% <87.5%> (-0.72%) :arrow_down:
src/model_main.f90 95.65% <0%> (+1.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1487ff0...a891957. Read the comment docs.

edoddridge commented 5 years ago

This pull request introduces 2 alerts when merging 630e6eff61a61083e831f8564b063fa1da951004 into 1487ff06184fb1980ea237a1af296b04e6f785e1 - view on LGTM.com

new alerts:

Comment posted by LGTM.com