search

edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
23 stars 5 forks source link

Bugfix: bottom drag #209

Closed edoddridge closed 5 years ago

edoddridge commented 5 years ago

Fixes #193 by ensuring that bottom drag is applied in all n-layer simulations, even when n=1.

For posterity, the methodology was:

  1. Build a test that identified the bug by failing when n=1, but not when n=2
  2. Fix the bug.
codecov[bot] commented 5 years ago

Codecov Report

Merging #209 into master will decrease coverage by 0.11%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #209      +/-   ##
=========================================
- Coverage   90.51%   90.4%   -0.12%     
=========================================
  Files          19      19              
  Lines        1613    1615       +2     
  Branches       82      84       +2     
=========================================
  Hits         1460    1460              
- Misses        127     128       +1     
- Partials       26      27       +1
Impacted Files Coverage Δ
src/momentum.f90 92.17% <100%> (+0.06%) :arrow_up:
src/model_main.f90 93.91% <0%> (-1.74%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update acb738c...aeb160b. Read the comment docs.