edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
23 stars 5 forks source link

Checkpoint bugfix #214

Closed edoddridge closed 5 years ago

edoddridge commented 5 years ago

The subroutine for writing checkpoints was using global indices for the local array. The tests didn't catch it because they didn't try restarting from a multicore simulation. New tests have been added that detect this bug, and it has been fixed.

codecov[bot] commented 5 years ago

Codecov Report

Merging #214 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   91.82%   91.82%           
=======================================
  Files          20       20           
  Lines        1822     1822           
  Branches       96       96           
=======================================
  Hits         1673     1673           
  Misses        124      124           
  Partials       25       25
Impacted Files Coverage Δ
src/io.f90 94.73% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32492b7...1d13272. Read the comment docs.