Closed edoddridge closed 5 years ago
Merging #216 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 91.82% 91.82%
=======================================
Files 20 20
Lines 1822 1822
Branches 96 96
=======================================
Hits 1673 1673
Misses 124 124
Partials 25 25
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 796acce...0ebd96b. Read the comment docs.
Ran some more serious benchmarks on the local cluster, using up to 64 cores for a 480x480 simulation.
The 1.5 layer simulation scales atrociously. There are far too many exchange calls, and we see very little benefit from the extra cores.
The 2 layer simulation scales acceptably - this is because the runtime is dominated by the matrix inversion, which scales very well. For larger numbers of CPUs the inefficiencies in the rest of the code become an increasingly large contributor to the runtime.