edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
24 stars 6 forks source link

bold on f and zeta since they are vectors #217

Closed navidcy closed 5 years ago

navidcy commented 5 years ago

I made f and zeta bold. (\mathbf has no effect on greek letters so I used \boldsymbol)

One remark: why g^{'} and not simply g'? The prime gets rendered so high up with ^{'}.

@edoddridge: Note that this PR is to be merged on your doc-fixes branch. Also, I only changed lines 63, 66. All other changes below must have to do with how are text editors handle line breaks. (It's been puzzling me long e.g. when interacting with @glwagner; if you have any idea why that happens let me know..)

codecov[bot] commented 5 years ago

Codecov Report

Merging #217 into docs-fixes will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           docs-fixes     #217   +/-   ##
===========================================
  Coverage       91.82%   91.82%           
===========================================
  Files              20       20           
  Lines            1822     1822           
  Branches           96       96           
===========================================
  Hits             1673     1673           
  Misses            124      124           
  Partials           25       25

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 380d487...850de34. Read the comment docs.

glwagner commented 5 years ago

@navidcy it might be how your text editor handles whitespace, not line breaks.

I have noticed some funny stuff with line breaks that occurs when one person uses Windows and another uses Mac, though.

navidcy commented 5 years ago

Indeed, it was atom:whitespace package's fault... I disabled the package. Thanks, @glwagner.

edoddridge commented 5 years ago

LGTM. Thanks @navidcy and welcome to the contributors list 🎉

One remark: why g^{'} and not simply g'? The prime gets rendered so high up with ^{'}.

Because that's what I started doing, but you're right - it looks better as g'.