search

edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
24 stars 6 forks source link

Bug in the SOR solver #219

Closed edoddridge closed 5 years ago

edoddridge commented 5 years ago

eta_star is only calculated for 1:nx and 1:ny, but the values one row/column outside this region get used by the SOR solver.

edoddridge commented 5 years ago

It's clear that this is in an issue with the SOR solver, because calculating eta_star in the halo does not affect the external solver results, but causes the SOR solver tests to fail.