search

edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
23 stars 5 forks source link

Open mfdataarray bigfix #223

Closed edoddridge closed 5 years ago

edoddridge commented 5 years ago

Fixe the bug identified in #222.

Rename 'time' to 'iter' since it doesn't represent model time, but actually represents iteration number from the main integration loop.

codecov[bot] commented 5 years ago

Codecov Report

Merging #223 into master will decrease coverage by <.01%. The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   91.76%   91.75%   -0.01%     
==========================================
  Files          20       20              
  Lines        1810     1808       -2     
  Branches       95       95              
==========================================
- Hits         1661     1659       -2     
  Misses        124      124              
  Partials       25       25
Impacted Files Coverage Δ
aronnax/core.py 95.3% <75%> (-0.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f7fdf64...48aad4c. Read the comment docs.

edoddridge commented 5 years ago

This pull request introduces 1 alert when merging 09b2b646c6ebe4e3b00d7f97db26e47ff489343b into f7fdf64fb4bc92d196424856f211aae104113e23 - view on LGTM.com

new alerts:

Comment posted by LGTM.com