search

edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
24 stars 6 forks source link

Update hypre repo url #229

Closed edoddridge closed 4 years ago

edoddridge commented 4 years ago

As described in #228, the repo url for hypre doesn't work. This PR replaces the old url with a new one.

closes #228

codecov[bot] commented 4 years ago

Codecov Report

Merging #229 into master will decrease coverage by 1.90%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   91.41%   89.50%   -1.91%     
==========================================
  Files          20       20              
  Lines        1886     1886              
  Branches      100      100              
==========================================
- Hits         1724     1688      -36     
- Misses        134      177      +43     
+ Partials       28       21       -7
Impacted Files Coverage Δ
src/momentum.f90 81.57% <0.00%> (-10.53%) :arrow_down:
src/model_main.f90 86.76% <0.00%> (-8.09%) :arrow_down:
aronnax/driver.py 92.30% <0.00%> (-1.71%) :arrow_down:
src/io.f90 95.69% <0.00%> (+0.35%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cdb1293...64f54b3. Read the comment docs.

renskegelderloos commented 3 years ago

Are you sure this is the right one? I still get an error (fatal: reference is not a tree [...]; Unable to checkout [...]), while cloning hypre directly from its github repository does work.

edoddridge commented 3 years ago

I'm confident that it was when this was merged. If it didn't work then the tests would have failed - the automated tests download and install the code on a virtual machine before running, and they all passed.