edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
23 stars 5 forks source link

Red grav bot drag #243

Closed edoddridge closed 1 year ago

edoddridge commented 1 year ago

Add bottom drag to reduced gravity simulations with an active lower layer.

Added code to allow this feature, and a test to make sure it works as expected.

codecov[bot] commented 1 year ago

Codecov Report

Merging #243 (f8459a4) into master (2424b32) will decrease coverage by 0.31%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   74.41%   74.10%   -0.32%     
==========================================
  Files          20       20              
  Lines        1419     1425       +6     
  Branches       85       89       +4     
==========================================
  Hits         1056     1056              
- Misses        313      315       +2     
- Partials       50       54       +4     
Impacted Files Coverage Δ
src/momentum.f90 66.43% <40.00%> (-2.91%) :arrow_down:
src/state_deriv.f90 80.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

edoddridge commented 1 year ago

The code coverage metrics are still wrong :( See #242 for details.

The new code is tested by a new test in physics_tests.py, since the effect of linear bottom drag can be easily predicted analytically.

Since all other tests pass, I'm going to merge this.