search

edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
24 stars 6 forks source link

Add a suite of low-dependency user-runnable self-tests #33

Open edoddridge opened 7 years ago

edoddridge commented 7 years ago

Having two of the tests fail because of a missing dependency (namely, valgrind) is suboptimal.

We should definitely keep valgrind in the test suite, but perhaps we don't set it to run every time.

Alternatively, we decide that the test suite is just for developers and Travis (as suggested in #32), so having some dependencies is not an issue.

axch commented 7 years ago

Yes, I think at this stage the thing to do is to have the test suite be developer-facing, and possibly add user-facing self-tests in the future. When it comes into being, the user-facing suite should indeed not depend on valgrind :)