search

edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
24 stars 6 forks source link

Missing term in SOR matrix solve #74

Closed edoddridge closed 7 years ago

edoddridge commented 7 years ago

The subroutine SOR_solver is missing a term in two different lines.

The value a(5,i,j) should instead be a(5,i,j) - freesurfFac/dt**2.

Given that this additional term doesn't change for the duration of the simulation, the additional term can be rolled into a in the derivatives_of_the_depth_field subroutine.

Confirming that this is affecting the results is a good test case for the automated tests described in #66.

axch commented 7 years ago

General comment on filing tickets like this: A Github url involving the word master always points to the tip of the master branch; so, if someone commits something that changes the number of lines preceding line 1346, the line pointers are liable to shift (unless the Github takes great pains to prevent this). More reliable (if more cumbersome) is pointing to a specific commit rather than the tip of the branch.

edoddridge commented 7 years ago

Thanks for the tip. I've updated it to point at a specific commit.