edoddridge / aronnax

An idealised isopycnal model that can be run either with n+1/2 layers, or with n layers and variable bathymetry.
http://aronnax.readthedocs.io/en/latest/
MIT License
24 stars 5 forks source link

Implement product shape #95

Closed axch closed 7 years ago

axch commented 7 years ago

Here is the external interface to Aronnax as I see it:

axch commented 7 years ago

Update: I have code almost ready for this and #96, pending some small cleanups.

edoddridge commented 7 years ago

I like the sound of this.

From reading this I get the impressions that the Fortran core will still output the raw Fortran files, but that the Python wrapper will then go scoop them up and output the data in NetCDF?

Using NetCDF for the input is definitely a nice portable way to do it. My only thought is that it involves a little more effort for the users to create the files than simply dumping out binaries. My feeling is that it's worth it.

axch commented 7 years ago

Oh, if the users want to dump binaries, I'm sure we can find a way for them to do that; but I'm presuming that NetCDF is a valuable format to support natively because users will have existing data (e.g., maps) in it.

edoddridge commented 7 years ago

That's true, but for the sorts of simulations Aronnx is likely to be used for, many users will simply create idealised basins and winds. Hence they may prefer to simply dump out binaries. However, if our wrapping makes is easy to create NetCDF files, then I don't think it's an issue.

axch commented 7 years ago

You'll be pleased to know that I haven't actually written any code for NetCDF input yet :) Also, my draft has a (undocumented) interface for plugging in our or one's own Python functions for idealized conditions, so I assume that will work out pretty well.

edoddridge commented 7 years ago

Aha! An interface for specifying idealised functions is pretty much perfect, and totally negates my comment.