search

edodson84 / Aosp_Dialer_10_Gradle

Aosp dialer 10 buildable
Apache License 2.0
18 stars 5 forks source link

License? #7

Open AndroidDeveloperLB opened 2 years ago

AndroidDeveloperLB commented 2 years ago

What is the license? Is this imported from official Android code? If so, how?

qw123wh commented 2 years ago

Apache 2.0 should be added. It's all taken from the aosp dialer code, just reorganized and optimized with build.gradle to make it work with android studio. In any case it should be added

AndroidDeveloperLB commented 2 years ago

OK please add it. Also, can you please explain how did you import it, step by step, so that future versions might come from other people?

edodson84 commented 2 years ago

I will add license. Didnt even think about it being its aosp code. I ported this based on a chinese repo and using apktool to decompile android 10 gsi dialer. It uses aosp 10 framework and various other source jars for libs. Can prob be simplified and use maven libs

AndroidDeveloperLB commented 2 years ago

@edodson84 I mean full step-by-step, so that everyone could do it too. Also, why is it Android 10 ? Is it the same as those after? I've also found a bug, that recent-call don't get updated in case the app isn't yet set as a Phone app.

edodson84 commented 2 years ago

I fully updated source to implementations instead of libs. Will update source and licenses tomorrow

AndroidDeveloperLB commented 2 years ago

@edodson84 I don't understand. You've re-implemented a lot of the code here, instead of what was originally used? If so, which parts? And which you've imported? Please explain all the things you had to do , from the point you've cloned some repository, to the point you have a working app.