edolstra / flake-compat

MIT License
251 stars 71 forks source link

Input boolean arguments might be being ignored/git submodules #20

Closed SomeoneSerge closed 2 years ago

SomeoneSerge commented 3 years ago

Flake inputs since recently support boolean arguments, including submodules = true for git inputs, which are supposed to trigger recursive checkout.

It seems, however, that flake-compat ignores those arguments:

Related:

charlesbaynham commented 2 years ago

Hi @SomeoneSerge, I ran into this too - did you find a workaround?

SomeoneSerge commented 2 years ago

Hello @charlesbaynham, I actually don't remember when have I last run into this problem (or the need to use flake inputs with submodules). Lately, I've been using the new builtins.getFlake instead of flake-compat, because I more often needed "shell.nix" for impure evaluation, rather than for handling flake-less installations of Nix

I haven't tested your PR yet, but I presume it would fix the issue