rkfg
commented
2 years ago Looks like the policy issue isn't solved by this. I opened a new channel and the incoming/outgoing policies were still reversed. They're shown fine if the channel was present before the program was started but for new channels it's a problem. I use Polar for testing, really great LN "simulator", it runs real bitcoind/lnd and other implementations in Docker containers and lets quickly create nodes and channels. I'll see what can be done.
The main issue is that policies aren't returned as a part of the channel data, they're requested separately and not even every time the channel is updated in the UI. The results can be also incomplete if gossip isn't yet propagated fully. And worst of all there's no "local" and "remote" side, just policy1 and policy2 which should be corresponded to local/remote sides using separate node1pub/node2pub parameters. A lot of moving parts and edge cases it seems...
edouardparis
This PR fixes a couple of annoyances:
nil. This should only happen when the channel is very new and the policy information isn't well propagated. It won't result in a big gRPC request inefficiency.closedinstead and mark all channels that aren't present in thelistchannelsresult as closed. Additionally I added channel status subscription, there was such a function already but its implementation was mostly commented out so I finished it. For now it simply triggers channel update when any channel is reported as fully resolved. To remove the closed channels from the list currently the user should restart the program. Maybe in the future it would be worth it to add a special key bind to fully refresh the channel information.There's also one more event subscription added, to graph events. Currently it only retrieves updated chan points and updates policies for corresponding channels. The rest of event information isn't used.
PS: there's also a very small alias cleanup that removes
\ufe0fcharacter because it breaks the UI. When the cursor is on that line all columns after the alias are shifted by 1 character to the left and some positions aren't redrawn after that. I think there are more such breaking characters but I've only encountered one in this node alias. PPS: I think fixing the underlying TUI library is a better solution but it might be a much harder task. I tried upgrading to the modern fork of gocui and the UI was in shambles, the columns were not lined up at all. Probably it needs more efforts to fix. The character I remove simply switches the previous symbol rendering from text-like to emoji-like (colored and shiny), cool thing to have but not at the cost of broken UI.