fees: IN/OUT fees flipped depending on local/remote initiation of a channel

edouardparis / lntop

:zap: LN terminal dashboard :bar_chart:

MIT License

183 stars 24 forks source link

fees: IN/OUT fees flipped depending on local/remote initiation of a channel #84

Closed hieblmi closed 2 years ago

hieblmi commented 2 years ago

There seems to be a bug in my implementation of displaying channel fees: https://github.com/edouardparis/lntop/pull/72

The IN/OUT fee columns are flipped I believe depending on who the channel was opened by.

If remote opened to us the channelPolicy_1 refers to their incoming fee rate but we currently treat channelPolicy_1 as outgoing only. When we open a channel respectively flips that view.

I am confirming and work on a fix.

hieblmi commented 2 years ago

Fixed in https://github.com/edouardparis/lntop/pull/76