search

edporras / edn_turbo

edn-ruby plugin to replace the ruby-native parser with a Ragel-based C++ implementation
MIT License
19 stars 7 forks source link

edn_turbo doesn't work on truffleruby #18

Open caleb opened 1 year ago

caleb commented 1 year ago

I get an argument count error when trying to use edn_turbo on truffle ruby when I call EDNT::Parser#read. I have a patch that seems to fix it: #17 but I'm not sure if the extra argument was there for a reason...

Edit: There are other issues on Truffleruby, but I thought this fix might be applicable to MRI as well.

edporras commented 1 year ago

ok, I see what you mean so I can't yet enabletruffle ruby in actions.

Does it work for me to leave it as is on devel or do you need a release with your MR?

caleb commented 1 year ago

You can leave it in devel. I made another change to make StringIO work. TruffleRuby’s StringIO is a T_OBJECT instead of a T_DATA.I might try to get this working more fully, but TruffleRuby is missing some key C level ruby functions.Sent from my iPhoneOn May 31, 2023, at 4:29 PM, Ed Porras @.***> wrote: ok, I see what you mean so I can't yet enabletruffle ruby in actions. Does it work for me to leave it as is on devel or do you need a release with your MR?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>