Closed gelosoftONCE closed 1 year ago
danielweck
commented
1 year ago Hello, thank you for filing this bug. Any change you could privately share the fileset with me please? (I am a lead developer in the Thorium project, my email address is daniel.weck@gmail.com )
gelosoftONCE
commented
1 year ago Hi! Thanks for your email! I'll upload the book (Daisy 3) with Wetransfer Kind regards!
El vie, 27 ene 2023 a las 20:39, Daniel Weck @.***>) escribió:
Hello, thank you for filing this bug. Any change you could privately share the fileset with me please? (I am a lead developer in the Thorium project, my email address is @.*** )
— Reply to this email directly, view it on GitHub https://github.com/edrlab/thorium-reader/issues/1905#issuecomment-1406992168, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5HOZUC4KBRLCCIINNROXDDWUQP6RANCNFSM6AAAAAAT2LCO7Y . You are receiving this because you authored the thread.Message ID: @.***>
danielweck
commented
1 year ago Hello, I am unable to reproduce this bug with Thorium 2.2 I tested with both the ZIP file, and also the unzipped publication (by choosing the OPF file)
danielweck
commented
1 year ago PS: in my tests the rendering of the DTBOOK XML file is very slow / janky. I am not sure if this is because of my specific Mac OS system settings, or if this is a general issue which also occurs on standard Mac OS and Windows / Linux too (I am seeing weird focus jump since I reconfigured by keyboard access / focus management ... I haven't found the cause yet). It is quite common to observe poor performance in Thorium with large XHTML documents, but in EPUB this is quite rare because the good authoring practice is to create a spine / reading order composed of reasonably-sized documents. In the DAISY3 / DTBOOK world large XML documents are much more common, unfortunately.
gelosoftONCE
commented
1 year ago Hi! Thank you very much for your time!! Maybe I don't understand your answer correctly, but I understand that the same problema doesn't happen to you, right? (...) Here, in ONCE (Organización Nacional de Ciegos Españoles), we work under Windows; and it's true, our XML Documents (in general) are "heavies". We have considered migrating to Epub3, but for now, it is not possible. We've also tried other players like EasyReader (Dolphin) o FSReader (Freedom Scientific), but honestly, we like Thorium better... Anyway, do you think this problem can be solved in the future? And the last thing, I just tried with a Daisy 2.02 book and it doesn't work either...
Thanks again! ¡Abrazos desde Madrid!
El mié, 8 feb 2023 a las 18:36, Daniel Weck @.***>) escribió:
PS: in my tests the rendering of the DTBOOK XML file is very slow / janky. I am not sure if this is because of my specific Mac OS system settings, or if this is a general issue which also occurs on standard Mac OS and Windows / Linux too (I am seeing weird focus jump since I reconfigured by keyboard access / focus management ... I haven't found the cause yet). It is quite common to observe poor performance in Thorium with large XHTML documents, but in EPUB this is quite rare because the good authoring practice is to create a spine / reading order composed of reasonably-sized documents. In the DAISY3 / DTBOOK world large XML documents are much more common, unfortunately.
— Reply to this email directly, view it on GitHub https://github.com/edrlab/thorium-reader/issues/1905#issuecomment-1422995654, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5HOZUEMEICM7JSTM26V4TLWWPKQJANCNFSM6AAAAAAT2LCO7Y . You are receiving this because you authored the thread.Message ID: @.***>
danielweck
commented
1 year ago You are correct, we are currently not able to reproduce the problem (tried on Linux and Mac ... need to check Windows too). We are investigating.
I would very much like to fix the performance problems with large DTBOOK XML files. A desktop app like Thorium should be able to render big HTML files without significant slow-downs (the open-source Chromium web browser engine is used to display publication documents).
Could you please send me a DAISY2.02 for testing? Thank you!
gautierchomel
commented
1 year ago I confirm I can reproduce the error on windows 10 Thorium 2.2 while trying to open opf file directly.
Opening the zip works fine.
gelosoftONCE
commented
1 year ago Hi! ¡it's true, the Zip works! Thanks!
danielweck
commented
1 year ago Ah, this was a tricky bug to fix (mainly because of tracing code execution on Windows and Mac to compare filesystem path resolutions) ... but in the end it was a stupid code mistake in one of Thorium's utility library where the backslash path separator of Windows filesystem wasn't handled correctly (only forward slash was correctly processed). The bug only affected non-zipped publication packages.
Hi! (From Madrid, Spain, ONCE) I can't open a Daisy 3 DTBook, the error message "publication manifest not defined" I have validated with DaisyPipeline 1: No errors Can you help me? OPF: