search

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.74k stars 152 forks source link

OPDS 1.2 search with Open Search is disabled #1978

Closed gotson closed 1 year ago

gotson commented 1 year ago

I am testing Thorium against the OPDS 1.2 feed of Komga, and noticed that the search is disabled in Thorium.

Here is the landing page of the catalog:

<feed xmlns="http://www.w3.org/2005/Atom">
    <id>root</id>
    <title>Komga OPDS catalog</title>
    <updated>2023-08-22T11:33:02.19292601+08:00</updated>
    <author>
        <name>Komga</name>
        <uri>https://github.com/gotson/komga</uri>
    </author>
    <link type="application/atom+xml;profile=opds-catalog;kind=navigation" rel="self" href="/opds/v1.2/catalog" />
    <link type="application/atom+xml;profile=opds-catalog;kind=navigation" rel="start" href="/opds/v1.2/catalog" />
    <link type="application/opensearchdescription+xml" rel="search" href="/opds/v1.2/search" />
    <entry>
        <title>Keep Reading</title>
        <updated>2023-08-22T11:33:02.193002386+08:00</updated>
        <id>keepReading</id>
        <content>Continue reading your in progress books</content>
        <link type="application/atom+xml;profile=opds-catalog;kind=navigation" rel="subsection"
            href="/opds/v1.2/keep-reading" />
    </entry>
    <entry>
        <title>On Deck</title>
        <updated>2023-08-22T11:33:02.19302544+08:00</updated>
        <id>ondeck</id>
        <content>Browse what to read next</content>
        <link type="application/atom+xml;profile=opds-catalog;kind=navigation" rel="subsection"
            href="/opds/v1.2/ondeck" />
    </entry>
    <entry>
        <title>All series</title>
        <updated>2023-08-22T11:33:02.193040499+08:00</updated>
        <id>allSeries</id>
        <content>Browse by series</content>
        <link type="application/atom+xml;profile=opds-catalog;kind=navigation" rel="subsection"
            href="/opds/v1.2/series" />
    </entry>
    <entry>
        <title>Latest series</title>
        <updated>2023-08-22T11:33:02.19305499+08:00</updated>
        <id>latestSeries</id>
        <content>Browse latest series</content>
        <link type="application/atom+xml;profile=opds-catalog;kind=navigation" rel="subsection"
            href="/opds/v1.2/series/latest" />
    </entry>
    <entry>
        <title>Latest books</title>
        <updated>2023-08-22T11:33:02.193070119+08:00</updated>
        <id>latestBooks</id>
        <content>Browse latest books</content>
        <link type="application/atom+xml;profile=opds-catalog;kind=navigation" rel="subsection"
            href="/opds/v1.2/books/latest" />
    </entry>
    <entry>
        <title>All libraries</title>
        <updated>2023-08-22T11:33:02.193084566+08:00</updated>
        <id>allLibraries</id>
        <content>Browse by library</content>
        <link type="application/atom+xml;profile=opds-catalog;kind=navigation" rel="subsection"
            href="/opds/v1.2/libraries" />
    </entry>
    <entry>
        <title>All collections</title>
        <updated>2023-08-22T11:33:02.193099183+08:00</updated>
        <id>allCollections</id>
        <content>Browse by collection</content>
        <link type="application/atom+xml;profile=opds-catalog;kind=navigation" rel="subsection"
            href="/opds/v1.2/collections" />
    </entry>
    <entry>
        <title>All read lists</title>
        <updated>2023-08-22T11:33:02.193114334+08:00</updated>
        <id>allReadLists</id>
        <content>Browse by read lists</content>
        <link type="application/atom+xml;profile=opds-catalog;kind=navigation" rel="subsection"
            href="/opds/v1.2/readlists" />
    </entry>
    <entry>
        <title>All publishers</title>
        <updated>2023-08-22T11:33:02.193128816+08:00</updated>
        <id>allPublishers</id>
        <content>Browse by publishers</content>
        <link type="application/atom+xml;profile=opds-catalog;kind=navigation" rel="subsection"
            href="/opds/v1.2/publishers" />
    </entry>
</feed>

And here is the content of /opds/v1.2/search :

<OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/">
    <ShortName>Search</ShortName>
    <Description>Search for series</Description>
    <InputEncoding>UTF-8</InputEncoding>
    <OutputEncoding>UTF-8</OutputEncoding>
    <Url template="/opds/v1.2/series?search={searchTerms}"
        type="application/atom+xml;profile=opds-catalog;kind=acquisition" />
</OpenSearchDescription>

Is this supported ?

I am using Thorium v2.2.0 on macOS 13.5

gotson commented 1 year ago

Tested on v2.3.0 and it seems to work now, closing.