search

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.68k stars 148 forks source link

GitHub Actions automated builds, Mac OS Intel vs. ARM (Apple Silicon), BROKEN! (both ARM) #2115

Closed danielweck closed 2 months ago

danielweck commented 2 months ago

https://github.com/edrlab/thorium-reader/releases

Screenshot 2024-05-02 at 15 15 54

https://github.com/edrlab/thorium-reader/blob/7df02042f797cad9f6fb37c106fa9adec527870c/.github/workflows/main.yml#L47-L54

https://github.com/edrlab/thorium-reader/blob/7df02042f797cad9f6fb37c106fa9adec527870c/.github/workflows/main.yml#L71-L73

https://github.com/edrlab/thorium-reader/blob/7df02042f797cad9f6fb37c106fa9adec527870c/.github/workflows/main.yml#L145

https://github.com/edrlab/thorium-reader/blob/7df02042f797cad9f6fb37c106fa9adec527870c/scripts/release-github.js#L377-L384

danielweck commented 2 months ago

https://github.com/actions/runner-images?tab=readme-ov-file#available-images

danielweck commented 2 months ago

xattr -l Thorium.app

(you will see “com.apple.quarantine”)

xattr -dr com.apple.quarantine Thorium.app

danielweck commented 2 months ago

https://github.com/edrlab/thorium-reader/actions/runs/8925670289/job/24514860893

Screenshot 2024-05-02 at 15 39 03
danielweck commented 2 months ago
Screenshot 2024-05-02 at 15 44 49
danielweck commented 2 months ago

https://github.com/edrlab/thorium-reader/actions/runs/8925918503/job/24515738245

Screenshot 2024-05-02 at 15 55 52
danielweck commented 2 months ago

Ok, so MacOS Intel same trick as before: context menu "open" (error message, "move to bin"), try again, now warning message but app can run. MacOS ARM Apple Silicon requires removing the quarantine flag