search

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.78k stars 153 forks source link

untyped dynamic translator keys causes loss of localised labels (scan doesn't discover them ... ejects) #2118

Closed danielweck closed 5 months ago

danielweck commented 5 months ago

https://github.com/edrlab/thorium-reader/commit/8b83bb22171cf8dc26597b0df25ee8515998b9bf#diff-fb56248986cf7338b6acb0c201a2269bc9ab3e18c7748f4bca7301fbb5fcf0d9R32

https://github.com/edrlab/thorium-reader/commit/3732f97c0df436dd68f25c17a4c6bc02560b4739#diff-a7df694e28b199bdb42f482b27cc21e905201b5c6a035233f082002685a8f2aaR594

https://github.com/edrlab/thorium-reader/commit/ee9213e3fe1fac61f85a252a6b89fb7ef12aa46f#diff-3c9531116fb804edd626844bd4d232fb92b7aa35ed6177e58ea64a9ed01308a6R95

const translate = __ as (str: string) => string;

danielweck commented 5 months ago

translate(`languages.${l}`)

translate("header." + item.label)