search

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.72k stars 151 forks source link

keyboard tab cycling gets stuck in the upper left corner when reverse tabbing (SHIFT TAB) #2148

Closed danielweck closed 3 months ago

danielweck commented 3 months ago
Screenshot 2024-05-06 at 18 31 22
danielweck commented 3 months ago
Screenshot 2024-05-06 at 18 33 49
panaC commented 3 months ago

https://github.com/radix-ui/primitives/blob/b32a93318cdfce383c2eec095710d35ffbd33a1c/packages/react/dialog/src/Dialog.tsx#L397C11-L397C15

https://github.com/radix-ui/primitives/blob/b32a93318cdfce383c2eec095710d35ffbd33a1c/packages/react/focus-scope/src/FocusScope.tsx#L197

panaC commented 3 months ago

As far I know, I'm stuck on this issue

panaC commented 3 months ago

I need help @danielweck to solve this issue

panaC commented 3 months ago

https://github.com/radix-ui/primitives/issues/966

danielweck commented 3 months ago

Will it be possible for Thorium to ultimately rely on a single technology solution like Adobe Spectrum / React ARIA Components (which under the hood uses React Stately and React ARIA Hooks), and avoid mixing other keyboard/focus-handling components from Radix? My understanding is that RACs are systematically and methodically tested with screen readers, with a great level of attention to detail. I am not sure that Radix focusses as hard on solving the finer issues. Maybe I am wrong though, not speaking from experience, just from listening / reading other developers' feedback.

danielweck commented 3 months ago

Duplicate: https://github.com/edrlab/thorium-reader/issues/2147