click outside dialog modal does not close it (works with publication info, not with reader modals)

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit

https://www.edrlab.org/software/thorium-reader/

BSD 3-Clause "New" or "Revised" License

1.68k stars 148 forks source link

click outside dialog modal does not close it (works with publication info, not with reader modals) #2149

Closed danielweck closed 2 months ago

danielweck commented 2 months ago

danielweck commented 2 months ago

...also, now that these 2 dialogs are true modals, their background needs to be darkened, just like the publication info dialog. This visually indicates the modal nature of the popup window, also goes hand-in-hand with the click outside behaviour.

panaC commented 2 months ago

will be fixed by #2143

danielweck commented 2 months ago

Works:

Does not work: