search

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.64k stars 145 forks source link

active tab styling discrepancy #2173

Closed danielweck closed 1 month ago

danielweck commented 1 month ago
Screenshot 2024-05-14 at 09 00 02
danielweck commented 1 month ago

reference:

Screenshot 2024-05-14 at 08 57 47
panaC commented 1 month ago

cf figma primary / secondary button

danielweck commented 1 month ago

cf figma primary / secondary button

just to clarify, does this mean that the current rendering is correct, or that the active tab button style must be consistent regardless of base app layer vs. popup dialog modal layer? (sorry, I am not familiar with the Figma details)

panaC commented 1 month ago

tab design in figma :

image

panaC commented 1 month ago

The reference seems wrong, no ? @arthur-lemeur The outline focus is not the same

panaC commented 1 month ago

fixed in develop