pagination selector is editable (arbitrary text can be entered)

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit

https://www.edrlab.org/software/thorium-reader/

BSD 3-Clause "New" or "Revised" License

1.68k stars 148 forks source link

pagination selector is editable (arbitrary text can be entered) #2224

Closed danielweck closed 2 months ago

danielweck commented 2 months ago

panaC commented 2 months ago

composant change to a combobox need to double check

arthur-lemeur commented 2 months ago

The problem we faced with the "SHIFT TAB" key combo was caused by the react-aria Select component, I changed it to a Combobox for now to make it work but yes didn't think of this side-effect..

panaC commented 2 months ago

will be fixed by #2294

danielweck commented 2 months ago

Fixed by replacing with native selectoption control: https://github.com/edrlab/thorium-reader/pull/2332#issuecomment-2127722233