search

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.68k stars 148 forks source link

wizard keep reappearing when switching tabs #2253

Closed danielweck closed 2 months ago

danielweck commented 2 months ago

the wizard should reappear at next app launch, not constantly during usage of the current application launch

Screenshot 2024-05-20 at 10 53 09 Screenshot 2024-05-20 at 10 53 23
danielweck commented 2 months ago

... actually, not just when switching tabs, also when adding OPDS feed etc. (GUI state refresh?)

arthur-lemeur commented 2 months ago

Doesn't happen on my end, still on yours?

danielweck commented 2 months ago

yes. make sure the checkbox is not ticked. then click outside the wizard modal or click the cross icon or press escape. Continue to use Thorium, change tabs ... the wizard keeps coming back which forces me to tick the "do not show again" checkbox, which was not my original intent (I WANTED to see the wizard again at next launch ... I don't want to see it popup every time I navigate my current application session :)

arthur-lemeur commented 2 months ago

Oh yes I see what you mean, I just fixed that in the latest PR (moved the wizard component from LibraryHeader.tsx to App.tsx)

danielweck commented 2 months ago

Ok will try :)