search

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.74k stars 152 forks source link

like keyboard shortcut editor, annotation editor should tab-cycle and lock keyboard, otherwise confusing screen reader experience #2260

Open danielweck opened 3 months ago

danielweck commented 3 months ago
Screenshot 2024-05-20 at 11 46 22
danielweck commented 3 months ago

there's very little UX benefit in allowing concurrent annotation edit, in fact I can only see negatives :)

danielweck commented 3 months ago

compare with keyboard shortcuts editor exclusive mode:

Screenshot 2024-05-20 at 11 48 41
panaC commented 3 months ago

https://github.com/edrlab/thorium-reader/blob/fe6304225d644d446b7f71ed94c2c4dbc071234e/src/renderer/reader/components/ReaderMenu.tsx#L471-L476

https://github.com/edrlab/thorium-reader/blob/fe6304225d644d446b7f71ed94c2c4dbc071234e/src/renderer/reader/components/ReaderMenu.tsx#L708-L728

panaC commented 3 months ago

Issue appear when I click on edit icon after scrolling in the modal, If i not scrolling the click on edit works.