search

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.73k stars 151 forks source link

Electron v30+ regression (since Thorium 2.4.2): window/globalThis.Response is undefined (was working in Electron v29) #2450

Closed danielweck closed 2 months ago

danielweck commented 2 months ago

This crashes:

new Response(cs.readable)

https://github.com/readium/r2-navigator-js/blob/9446f5efb65540500a8d1b99afb0ef11222beb05/src/electron/renderer/location.ts#L1543

https://github.com/readium/r2-navigator-js/blob/9446f5efb65540500a8d1b99afb0ef11222beb05/src/electron/renderer/location.ts#L1602C52-L1602C58

danielweck commented 2 months ago

Electron fix: https://github.com/electron/electron/pull/42419

Already reported bugs:

https://github.com/electron/electron/issues/42457

https://github.com/electron/electron/issues/42381

danielweck commented 2 months ago
Screenshot 2024-06-12 at 17 11 23 Screenshot 2024-06-12 at 17 10 39
danielweck commented 2 months ago

Fixed in:

danielweck commented 2 months ago

Thorium 2.4.1: https://github.com/edrlab/thorium-reader/blob/50dfbc3e19774307cfd9219f9cb78c80992dda65/package.json#L354

Thorium 2.4.2: https://github.com/edrlab/thorium-reader/blob/e828405e8d80e5e19e083c50da0d1a08c346bf17/package.json#L354