search

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.64k stars 145 forks source link

Endnotes Pop-up #2478

Open VijayShankar1 opened 4 days ago

VijayShankar1 commented 4 days ago

We are captured the Endnotes in correct coding structure only. However in the new version of Thorium 3.0.0 shows blanks pop-up boxes. It looks like a bug in Thorium reader v3.0.0 but the previous version 2.4.1 the pop-up is working fine. We have placed the Thorium v3.0.0 and Thorium v2.4.1 screenshot for your reference. Thanks!

Screenshot v3.0.0

image

Screenshot v2.4.1

image

danielweck commented 4 days ago

hello, it looks like your footnote content is a backlink, which is now excluded by design / intentionally. Could you please share the HTML code of your note content? (or ideally the EPUB to test)

VijayShankar1 commented 4 days ago

Hi Daniel Weck,

Please find the HTML coding as given below for your reference. Thanks!

The idea of this book originated from reflection about translating the term “public history” into the Polish language. A literal translation (“historia publiczna”) did not ring well in contemporary mainstream Polish, potentially carrying distorting connotations. Because of the way the adjective “public” (“publiczna”) had historically functioned in Polish, “historia publiczna” could connote: lacking intellectual value; aimed solely at mass entertainment; associated with prostitution. The use in Polish academic discourse of the English term “public history” (or other foreign-language borrowings) is barred under the provisions of the Polish Language Act, which also governed the launching of the Masters program at the University of Wrocław in 2014. Moreover, using only the English term would pose the risk of highjacking and/or alienation: people might reject it, without grasping its actual meaning. This is what happened with the word “gender”: when first introduced in its English version, it was publicly reviled, mis-cast, and politized, as something borrowed, alien, strange, and incomprehensible.1 …

  • Cf. Agnieszka Graff and Elżbieta Korolczuk, Kto się boi gender? Prawica, populizm i feministyczne strategie oporu (Warszawa: Wydawnictwo Krytyki Politycznej, 2022).

    • Regards, Vijayashankar S

    From: Daniel Weck @.> Sent: 01 July 2024 19:08 To: edrlab/thorium-reader @.> Cc: Vijayashankar S @.>; Author @.> Subject: Re: [edrlab/thorium-reader] Endnotes Pop-up (Issue #2478)

    CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

    hello, it looks like your footnote content is a backlink, which is now excluded by design / intentionally. Could you please share the HTML code of your note content? (or ideally the EPUB to test)

    — Reply to this email directly, view it on GitHubhttps://github.com/edrlab/thorium-reader/issues/2478#issuecomment-2200185210, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZB3JILGTRUEROKSRYAYJ7TZKFLS7AVCNFSM6AAAAABKFM44XGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGE4DKMRRGA. You are receiving this because you authored the thread.Message ID: @.***>

    Disclaimer: This e-mail and/or attachments are confidential and may also be legally privileged. If you are not the intended recipient, any disclosure, copying, distribution or action taken relying on the contents is strictly prohibited and may be unlawful. If you have received this communication in error, please notify the sender immediately by responding to this e-mail and deleting the contents of the e-mail & related attachments from your system. Though MPS Limited has taken reasonable steps to ensure no viruses are present in this e-mail, it cannot accept responsibility for any loss or damage arising from the use of this e-mail or attachments. No contracts may be concluded with MPS through e-mail communication. Please consider the environment before printing this e-mail.

    danielweck commented 4 days ago

    just as I suspected: the HTML link tag ('a' XML element) that carries the 'role' and 'epub:type' attributes with value "backlink" should only contain the hyperlink text, not the actual content of the endnote / footnote. By design, Thorium now intentionally excludes backlinks from popup footnote content. This was a feature request which made a lot of sense, as by its very definition the popup GUI affordance integrates its own backlink behaviour (i.e. returning to the link's originating callsite)

    dazrand commented 4 days ago

    Interesting interpretation, but the use of 'noteref' which creates the footnote behaviour is used for all notes, both endnotes and footnotes. While footnotes tend, but not always, have a leading character in the main element, endnotes should use the automatic numbering feature which only leaves content available for backlinks. Perhaps this is a failing in the structural semantics specification, perhaps there should be an effort to separate footnotes and endnotes.

    danielweck commented 4 days ago

    cc @gregoriopellegrino re. backlink exclusion in popup footnotes GUI affordance

    gregoriopellegrino commented 3 days ago

    The markup shown looks like an export from InDesign of some past version where the software placed all the note text inside a link. This does not look like good practice to me.

    That said a possible solution for @danielweck is to check if there is only the link in the note (in which case don't hide it), or if there is link + text, in which case you can hide it.

    danielweck commented 3 days ago

    backlink links inside popup footnotes are currently hidden with CSS display:none triggered by a simple CSS selector rule. In order to add smart link vs. content heuristics we would need to introduce yet more JavaScript, which frankly seems like over-engineering a solution to a problem that shouldn't exist in the first place :) That being said, I wonder if we could write a CSS selector that ensures that is at least one sibling element next to the backlink (which we could infer as the notes contents )

    dazrand commented 3 days ago

    Would it be easier to only populate the popup when the destination is an @epub:type='footnote'? Then treat other 'noteref' links as regular links?

    danielweck commented 3 days ago

    do you mean to exclude epub:type=endnote, for example?

    dazrand commented 3 days ago

    In effect, yes.

    danielweck commented 3 days ago

    isn't the backlink role allowed on links inside targeted footnote destinations though? (in which case the selective rendering isn't helping solve the problem)

    dazrand commented 3 days ago

    Good question, the short answer is yes, the structural semantics even cites returning from a footnote in the use of a backlink. If all reading systems did footnotes as popups, the backlink we could petition to have backlink dropped in favor of the reader handling the navigation, but that is a way off I fear.

    To complicate things, a creative author could have multiple links leading to a given footnote, which could require multiple backlinks exiting the footnote, but I have not seen this in general practice so very much and edge case.

    gregoriopellegrino commented 2 days ago

    I think backlinks are useful, for example if a person unzips an EPUB and reads it in a browser or in the case of very simple reading solutions.

    That said it seems to me that the problem with this issue is not so much the reading solution, but the endnotes exported "badly" by InDesign with all the text rendered as links, which creates problems when there is an external link in the endnote. Fortunately in the latest version of InDesign the export of endnotes has improved.

    dazrand commented 2 days ago

    Endnotes with backlinks give easy navigation back to the main point in text. Selection of parts, or the complete, endnote is common especially when the

      numbering is used (as it should be). Since this relates to the popup it really only applies to the footnote since the endnote is still represented, intact, in the relevant position. Ideally it is the footnote which should lose the backlink, since its appearance should be driven completely by the viewing software, but not all software is as capable.

    danielweck commented 1 day ago

    in Thorium the content of endnotes / footnotes / rearnotes is hidden by the reading system when they are inside 'aside' elements, IIRC (and only when the popup footnote feature is active) otherwise, when other note HTML containers are used, the content remains visible / reachable in the document reading order.

    danielweck commented 1 day ago

    ...and for the avoidance of doubt, the feature named "popup footnotes" should really be called "modal popup contents viewport for notes that are references by hyperlinks with role=noteref" ;)

    gregoriopellegrino commented 1 day ago

    In the meantime, I am working on a CSS selector that will solve the situation