[CSS] input type=text outline

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit

https://www.edrlab.org/software/thorium-reader/

BSD 3-Clause "New" or "Revised" License

1.86k stars 157 forks source link

[CSS] input type=text outline #2578

Closed panaC closed 1 month ago

panaC commented 1 month ago

see example on getpocket.com

danielweck commented 1 month ago

I think that the global focus mixin needs to be removed? (not sure if there are local CSS rules for each component?) The global mixin was inherited from pre-3.0 Thorium when we had a thick blue high-contrast keyboard focus outline everywhere (the 3.0 redesign replaced this with the more pastel theme in order to offer consistent visuals across the GUI). As you know I prefer the old vivid blue outline but I am in a minority ;)

panaC commented 1 month ago

For the moment, I just close this issue with the PR, the Figma design is respected and with the last fixes from Arthur, it is visually better. Let's continue the discussion about this global mixin in a next time with Arthur :)

danielweck commented 1 month ago

oh yeah sure, I align with the team consensus, I just wanted to explain the origins of the mixin (which may or may not be needed in the context of the SASS / JSX components refactoring, I just don't know :)