edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.86k stars 157 forks source link

Chapter endnotes fail to display on mac desktop app #2596

Closed dm5n closed 2 weeks ago

dm5n commented 1 month ago

Hello, the Notes section at the end of each chapter fail to display on Thorium 3 on macOS 15.0.1

The Notes section displays properly on my Android epub reader (Librera).

Screenshot 2024-10-06 at 22 43 57

danielweck commented 1 month ago

hello, please try disabling the "popup footnotes" in Thorium's configuration.

dm5n commented 1 month ago

Yes, that fixed it.

The setting was 'Disable footnotes' in the individual book's settings under the 'Aa' icon.

Perhaps this setting could be better worded 'Popup footnotes' or 'Enable inline footnotes' or similar?

In any case, Thankyou :)

danielweck commented 2 weeks ago

This is a tricky UX problem ... personally I have never been a fan of automatically hiding sections marked with the footnotes/endnotes role (especially as this only applies to aside, not to other HTML containers). But I know there are users who expect this behaviour when the EPUB "popup footnotes" feature is activated. I am converting this issue to a discussion...