edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.86k stars 157 forks source link

Headings for tabs in Settings Dialogue create relationships that are not perceivable to screen reader users #2600

Closed togregg closed 4 weeks ago

togregg commented 1 month ago

ISSUE - Headings for tabs in Settings Dialogue create relationships that are not perceivable to screen reader users

Impact: Minor

WCAG 2.1 SC 1.3.1: Info and Relationships

Current Behavior:

Under the General tab in Thorium, heading level jumps from 2 to 4. Level 3 headings are skipped, even though the items are related to the level 2 headings. Using VoiceOver and NVDA, General, Appearance and Keyboard Shortcuts are level 4 headings, while the items under those tabs are level 2 headings. Using JAWS, General, Keyboard Shortcuts and Appearance are level 2 headings, while the items under those tabs are level 4 headings.

Example:

Under Settings when you activate the General tab using JAWS, General is a level 2 heading. Login and Do you want to save the session are level 4 headings.

Expected Behavior:

Heading levels would go from 2 to 3, or the level 4 headings can be removed entirely in the tab panels.

Machine Details:

Windows

macOS

Steps to recreate:

  1. In Thorium navigate to the Settings button and activate it.
  2. General tab is selected by default. Navigate by headings to explore the layout.
    • JAWS, press Insert-F6, then down-arrow to explore the headings.
    • NVDA: Press Insert-F7, then filter by headings. Use down-arrow to explore the headings.
    • VO: Press CTRL-Option-Command-u and choose headings from the rotor. Press down-arrow to explore the headings.
  3. If only one heading is in focus, press Tab to the first option past the Close button and explore the headings.

Video(s)/Screenshots:

image

image

Recommendations: