edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.86k stars 157 forks source link

Non-standard keyboard commands required to navigate and edit keyboards shortcuts in Settings dialogue using screen readers #2601

Closed togregg closed 1 week ago

togregg commented 1 month ago

ISSUE - Non-standard keyboard commands required to navigate and edit keyboards shortcuts in Settings dialogue using screen readers

Impact: Minor

WCAG 2.1 SC 1.3.1 - Info and Relationships (Level A) WCAG 2.1 SC 1.3.2 - Meaningful Sequence (Level A)

Current Behavior:

From the Settings dialogue, once the Keyboard shortcuts tab is selected, and you Tab over to the options for Keyboard Shortcut, you cannot use standard screen reader keyboard commands to navigate through the edit buttons for Keyboard shortcuts. In order to get to the edit button for each keyboard shortcut you must press Tab. This means you can't use the standard screen reader commands for navigation and end up missing the heading and note about QWERTY layout above the keyboard shortcuts.

Example:

Using VoiceOver while in the settings dialogue, navigate to the Keyboard Shortcuts tab, activate it and then tab over to the options for Keyboard shortcuts. Using VO+ Right arrow to navigate you go past the Keyboards shortcuts heading, menu, Close window button, text saying “Shortcuts were defined from QWERTY keyboard layout.”. Pressing VO + Right arrow again VoiceOver announces end of keyboard shortcuts tab panel. You can’t go any further with standard navigation command. To access the edit buttons, you must tab to each one.

Expected Behavior:

From the Settings dialogue, once the Keyboard shortcuts tab is selected, and you Tab over to the options for Keyboard Shortcut, you can use standard screen reader keyboard commands to navigate through the edit buttons for Keyboard shortcuts.

Machine Details:

Windows

macOS

Steps to recreate:

  1. Start your screen reader of choice.
  2. Launch Thorium 3.0.0.
  3. Using the standard navigation keyboard commands for your screen reader, navigate to and activate the Settings button.
    • JAWS/NVDA – Down arrow
    • VoiceOver – Ctrl + Option + Right Arrow
  4. From the dialogue that appears, navigate up from the Close window button until you get to Keyboards shortcuts tab.
  5. Press Tab to go to the contents for Keyboard Shortcuts.
  6. Use the standard navigation keyboard commands for your screen reader, go down to the text “Shortcuts were defined from QWERTY keyboard layout”.
    • JAWS/NVDA – Down arrow
    • VoiceOver – Ctrl + Option + Right Arrow
  7. Try using the standard navigation command again…nothing should happen (outside of silence or a ding, depending on your screen reader).
  8. Press Tab and you will be on the first edit button for a keyboard shortcut.

Video(s)/Screenshots:

Recommendations: