search

edrlab / thorium-reader

A cross platform desktop reading app, based on the Readium Desktop toolkit
https://www.edrlab.org/software/thorium-reader/
BSD 3-Clause "New" or "Revised" License
1.86k stars 157 forks source link

Request: change Appimage package naming convention #2604

Closed BBBalls closed 1 month ago

BBBalls commented 1 month ago

I utilize the Linux application Gear Lever to manage Appimages. It has a feature for updating Appimages by checking and downloading from GitHub. The updating feature requires providing a slightly altered release url, with the variable parts replaced with an *.

The current naming convention amd64 version of the Appimage doesn't allow for the updating feature to work properly. The modified release url for the amd64 Appimage is https://github.com/edrlab/thorium-reader/releases/download/*/Thorium-*.AppImage, but the arm64 version also fits the variable, and is what is downloaded as an update.

It would be appreciated if the amd64 Appimage release filename convention is changed to include the processor architecture, e.g. Thorium-3.0.0-amd64.AppImage. This would allow for creating a more specific release update link, e.g. https://github.com/edrlab/thorium-reader/releases/download/*/Thorium-*-amd64.AppImage.

Thank you for the great reading application.

danielweck commented 1 month ago

Hello, we too have to work around this inconsistent naming convention, which we inherit from Electron Builder https://github.com/electron-userland/electron-builder

I am afraid I am not willing to change this convention as this would break our build scripts and processes. Sorry.